Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

false duplicates are possible #55

Open
rhansen opened this issue Jun 15, 2016 · 0 comments
Open

false duplicates are possible #55

rhansen opened this issue Jun 15, 2016 · 0 comments

Comments

@rhansen
Copy link
Member

rhansen commented Jun 15, 2016

The current duplicate RPKI object detection isn't strict enough. Malicious repositories could cause collisions of malicious objects with benign objects, invalidating those benign objects. Ideally duplicate detection should be done at the level of file hash.

Also see #28.
rhansen added a commit to rhansen/rpstir that referenced this issue Jun 25, 2016
@rhansen
delete signature validation state code
027013f 
The purpose of this code appears to be verification acceleration:
avoid performing expensive crypto work when the object has already
been verified.  (The purpose isn't entirely clear due to lack of
explanatory comments.)  However:

  * It's unclear that this code actually improves performance in any
    perceptable way.  First, it's unclear how often an object is added
    multiple times.  Second, it's trading crypto work for database
    operations.

  * This code permits evil twin ROAs:  A malicious CA can generate an
    evil ROA with an EE certificate containing the same SKI as a valid
    EE certificate.  The malicious CA won't be able to produce a valid
    signature for the evil ROA, but that doesn't matter because this
    code shortcuts the signature check.  Fortunately there's another
    bug preventing this from being exploitable (issue bgpsecurity#55).
rhansen added a commit to rhansen/rpstir that referenced this issue Jun 25, 2016
@rhansen
delete signature validation state code
15dcd48 
The purpose of this code appears to be verification acceleration:
avoid performing expensive crypto work when the object has already
been verified.  (The purpose isn't entirely clear due to lack of
explanatory comments.)  However:

  * It's unclear that this code actually improves performance in any
    perceptable way.  First, it's unclear how often an object is added
    multiple times.  Second, it's trading crypto work for database
    operations.

  * This code permits evil twin ROAs:  A malicious CA can generate an
    evil ROA with an EE certificate containing the same SKI as a valid
    EE certificate.  The malicious CA won't be able to produce a valid
    signature for the evil ROA, but that doesn't matter because this
    code shortcuts the signature check.  Fortunately there's another
    bug preventing this from being exploitable (issue bgpsecurity#55).
rhansen added a commit to rhansen/rpstir that referenced this issue Jun 25, 2016
@rhansen
delete signature validation state code
c08333d 
The purpose of this code appears to be verification acceleration:
avoid performing expensive crypto work when the object has already
been verified.  (The purpose isn't entirely clear due to lack of
explanatory comments.)  However:

  * It's unclear that this code actually improves performance in any
    perceptable way.  First, it's unclear how often an object is added
    multiple times.  Second, it's trading crypto work for database
    operations.

  * This code permits evil twin ROAs:  A malicious CA can generate an
    evil ROA with an EE certificate containing the same SKI as a valid
    EE certificate.  The malicious CA won't be able to produce a valid
    signature for the evil ROA, but that doesn't matter because this
    code shortcuts the signature check.  Fortunately there's another
    bug preventing this from being exploitable (issue bgpsecurity#55).
rhansen added a commit to rhansen/rpstir that referenced this issue Jun 25, 2016
@rhansen
delete signature validation state code
59feb47 
The purpose of this code appears to be verification acceleration:
avoid performing expensive crypto work when the object has already
been verified.  (The purpose isn't entirely clear due to lack of
explanatory comments.)  However:

  * It's unclear that this code actually improves performance in any
    perceptable way.  First, it's unclear how often an object is added
    multiple times.  Second, it's trading crypto work for database
    operations.

  * This code permits evil twin ROAs:  A malicious CA can generate an
    evil ROA with an EE certificate containing the same SKI as a valid
    EE certificate.  The malicious CA won't be able to produce a valid
    signature for the evil ROA, but that doesn't matter because this
    code shortcuts the signature check.  Fortunately there's another
    bug preventing this from being exploitable (issue bgpsecurity#55).
rhansen added a commit to rhansen/rpstir that referenced this issue Jun 25, 2016
@rhansen
delete signature validation state code
73f9856 
The purpose of this code appears to be verification acceleration:
avoid performing expensive crypto work when the object has already
been verified.  (The purpose isn't entirely clear due to lack of
explanatory comments.)  However:

  * It's unclear that this code actually improves performance in any
    perceptable way.  First, it's unclear how often an object is added
    multiple times.  Second, it's trading crypto work for database
    operations.

  * This code permits evil twin ROAs:  A malicious CA can generate an
    evil ROA with an EE certificate containing the same SKI as a valid
    EE certificate.  The malicious CA won't be able to produce a valid
    signature for the evil ROA, but that doesn't matter because this
    code shortcuts the signature check.  Fortunately there's another
    bug preventing this from being exploitable (issue bgpsecurity#55).
rhansen added a commit to rhansen/rpstir that referenced this issue Jun 27, 2016
@rhansen
delete signature validation state code
18b3344 
The purpose of this code appears to be verification acceleration:
avoid performing expensive crypto work when the object has already
been verified.  (The purpose isn't entirely clear due to lack of
explanatory comments.)  However:

  * It's unclear that this code actually improves performance in any
    perceptable way.  First, it's unclear how often an object is added
    multiple times.  Second, it's trading crypto work for database
    operations.

  * This code permits evil twin ROAs:  A malicious CA can generate an
    evil ROA with an EE certificate containing the same SKI as a valid
    EE certificate.  The malicious CA won't be able to produce a valid
    signature for the evil ROA, but that doesn't matter because this
    code shortcuts the signature check.  Fortunately there's another
    bug preventing this from being exploitable (issue bgpsecurity#55).
rhansen added a commit to rhansen/rpstir that referenced this issue Jun 27, 2016
@rhansen
delete signature validation state code
d00c004 
The purpose of this code appears to be verification acceleration:
avoid performing expensive crypto work when the object has already
been verified.  (The purpose isn't entirely clear due to lack of
explanatory comments.)  However:

  * It's unclear that this code actually improves performance in any
    perceptable way.  First, it's unclear how often an object is added
    multiple times.  Second, it's trading crypto work for database
    operations.

  * This code permits evil twin ROAs:  A malicious CA can generate an
    evil ROA with an EE certificate containing the same SKI as a valid
    EE certificate.  The malicious CA won't be able to produce a valid
    signature for the evil ROA, but that doesn't matter because this
    code shortcuts the signature check.  Fortunately there's another
    bug preventing this from being exploitable (issue bgpsecurity#55).
rhansen added a commit to rhansen/rpstir that referenced this issue Jun 27, 2016
@rhansen
delete signature validation state code
2ce35f3 
The purpose of this code appears to be verification acceleration:
avoid performing expensive crypto work when the object has already
been verified.  (The purpose isn't entirely clear due to lack of
explanatory comments.)  However:

  * It's unclear that this code actually improves performance in any
    perceptable way.  First, it's unclear how often an object is added
    multiple times.  Second, it's trading crypto work for database
    operations.

  * This code permits evil twin ROAs:  A malicious CA can generate an
    evil ROA with an EE certificate containing the same SKI as a valid
    EE certificate.  The malicious CA won't be able to produce a valid
    signature for the evil ROA, but that doesn't matter because this
    code shortcuts the signature check.  Fortunately there's another
    bug preventing this from being exploitable (issue bgpsecurity#55).
rhansen added a commit to rhansen/rpstir that referenced this issue Jun 27, 2016
@rhansen
delete signature validation state code
490a8a9 
The purpose of this code appears to be verification acceleration:
avoid performing expensive crypto work when the object has already
been verified.  (The purpose isn't entirely clear due to lack of
explanatory comments.)  However:

  * It's unclear that this code actually improves performance in any
    perceptable way.  First, it's unclear how often an object is added
    multiple times.  Second, it's trading crypto work for database
    operations.

  * This code permits evil twin ROAs:  A malicious CA can generate an
    evil ROA with an EE certificate containing the same SKI as a valid
    EE certificate.  The malicious CA won't be able to produce a valid
    signature for the evil ROA, but that doesn't matter because this
    code shortcuts the signature check.  Fortunately there's another
    bug preventing this from being exploitable (issue bgpsecurity#55).
rhansen added a commit to rhansen/rpstir that referenced this issue Jun 28, 2016
@rhansen
delete signature validation state code
fa88c65 
The purpose of this code appears to be verification acceleration:
avoid performing expensive crypto work when the object has already
been verified.  (The purpose isn't entirely clear due to lack of
explanatory comments.)  However:

  * It's unclear that this code actually improves performance in any
    perceptable way.  First, it's unclear how often an object is added
    multiple times.  Second, it's trading crypto work for database
    operations.

  * This code permits evil twin ROAs:  A malicious CA can generate an
    evil ROA with an EE certificate containing the same SKI as a valid
    EE certificate.  The malicious CA won't be able to produce a valid
    signature for the evil ROA, but that doesn't matter because this
    code shortcuts the signature check.  Fortunately there's another
    bug preventing this from being exploitable (issue bgpsecurity#55).
rhansen added a commit to rhansen/rpstir that referenced this issue Jun 29, 2016
@rhansen
delete signature validation state code
8244144 
The purpose of this code appears to be verification acceleration:
avoid performing expensive crypto work when the object has already
been verified.  (The purpose isn't entirely clear due to lack of
explanatory comments.)  However:

  * It's unclear that this code actually improves performance in any
    perceptable way.  First, it's unclear how often an object is added
    multiple times.  Second, it's trading crypto work for database
    operations.

  * This code permits evil twin ROAs:  A malicious CA can generate an
    evil ROA with an EE certificate containing the same SKI as a valid
    EE certificate.  The malicious CA won't be able to produce a valid
    signature for the evil ROA, but that doesn't matter because this
    code shortcuts the signature check.  Fortunately there's another
    bug preventing this from being exploitable (issue bgpsecurity#55).
rhansen added a commit to rhansen/rpstir that referenced this issue Jun 29, 2016
@rhansen
delete signature validation state code
591e835 
The purpose of this code appears to be verification acceleration:
avoid performing expensive crypto work when the object has already
been verified.  (The purpose isn't entirely clear due to lack of
explanatory comments.)  However:

  * It's unclear that this code actually improves performance in any
    perceptable way.  First, it's unclear how often an object is added
    multiple times.  Second, it's trading crypto work for database
    operations.

  * This code permits evil twin ROAs:  A malicious CA can generate an
    evil ROA with an EE certificate containing the same SKI as a valid
    EE certificate.  The malicious CA won't be able to produce a valid
    signature for the evil ROA, but that doesn't matter because this
    code shortcuts the signature check.  Fortunately there's another
    bug preventing this from being exploitable (issue bgpsecurity#55).
rhansen added a commit to rhansen/rpstir that referenced this issue Jul 31, 2016
@rhansen
delete signature validation state code
6d9d797 
The purpose of this code appears to be verification acceleration:
avoid performing expensive crypto work when the object has already
been verified.  (The purpose isn't entirely clear due to lack of
explanatory comments.)  However:

  * It's unclear that this code actually improves performance in any
    perceptable way.  First, it's unclear how often an object is added
    multiple times.  Second, it's trading crypto work for database
    operations.

  * This code permits evil twin ROAs:  A malicious CA can generate an
    evil ROA with an EE certificate containing the same SKI as a valid
    EE certificate.  The malicious CA won't be able to produce a valid
    signature for the evil ROA, but that doesn't matter because this
    code shortcuts the signature check.  Fortunately there's another
    bug preventing this from being exploitable (issue bgpsecurity#55).
rhansen added a commit to rhansen/rpstir that referenced this issue Apr 17, 2020
@rhansen
delete signature validation state code
6657ff4 
The purpose of this code appears to be verification acceleration:
avoid performing expensive crypto work when the object has already
been verified.  (The purpose isn't entirely clear due to lack of
explanatory comments.)  However:

  * It's unclear that this code actually improves performance in any
    perceptable way.  First, it's unclear how often an object is added
    multiple times.  Second, it's trading crypto work for database
    operations.

  * This code permits evil twin ROAs:  A malicious CA can generate an
    evil ROA with an EE certificate containing the same SKI as a valid
    EE certificate.  The malicious CA won't be able to produce a valid
    signature for the evil ROA, but that doesn't matter because this
    code shortcuts the signature check.  Fortunately there's another
    bug preventing this from being exploitable (issue bgpsecurity#55).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhansen