Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump rev fix typos #41

Merged
merged 6 commits into from
Dec 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ permissions:
checks: read
statuses: read
pull-requests: write
contents: write

jobs:
comment:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,20 +47,20 @@ jobs:
run: npm ci --prefer-offline --no-audit

- name: Run Foundry setup
uses: bgd-labs/github-workflows/.github/actions/foundry-setup@d738561b5afce35ca3752b28236c9dd68a3fa822
uses: bgd-labs/github-workflows/.github/actions/foundry-setup@4f16d15e380bbcf7e3933698c08b9fd34e967f78

- name: Run Forge tests
uses: bgd-labs/github-workflows/.github/actions/foundry-test@d738561b5afce35ca3752b28236c9dd68a3fa822
uses: bgd-labs/github-workflows/.github/actions/foundry-test@4f16d15e380bbcf7e3933698c08b9fd34e967f78

- name: Run Gas report
uses: bgd-labs/github-workflows/.github/actions/foundry-gas-report@d738561b5afce35ca3752b28236c9dd68a3fa822
uses: bgd-labs/github-workflows/.github/actions/foundry-gas-report@4f16d15e380bbcf7e3933698c08b9fd34e967f78

- name: Cleanup
# This test will currently fail on coverage due to the gas limit beaing breached with optimizer disabled
run: rm tests/deployments/DeploymentsGasLimits.t.sol

- name: Run Lcov report
uses: bgd-labs/github-workflows/.github/actions/foundry-lcov-report@d738561b5afce35ca3752b28236c9dd68a3fa822
uses: bgd-labs/github-workflows/.github/actions/foundry-lcov-report@4f16d15e380bbcf7e3933698c08b9fd34e967f78

- name: Save PR number
if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target'
Expand Down
1,529 changes: 0 additions & 1,529 deletions docs/3.3/gas-diff.md

This file was deleted.

2 changes: 1 addition & 1 deletion src/contracts/instances/PoolConfiguratorInstance.sol
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ pragma solidity ^0.8.0;
import {PoolConfigurator, IPoolAddressesProvider, IPool, VersionedInitializable} from '../protocol/pool/PoolConfigurator.sol';

contract PoolConfiguratorInstance is PoolConfigurator {
uint256 public constant CONFIGURATOR_REVISION = 4;
uint256 public constant CONFIGURATOR_REVISION = 5;

/// @inheritdoc VersionedInitializable
function getRevision() internal pure virtual override returns (uint256) {
Expand Down
2 changes: 1 addition & 1 deletion src/contracts/instances/PoolInstance.sol
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {IPoolAddressesProvider} from '../interfaces/IPoolAddressesProvider.sol';
import {Errors} from '../protocol/libraries/helpers/Errors.sol';

contract PoolInstance is Pool {
uint256 public constant POOL_REVISION = 6;
uint256 public constant POOL_REVISION = 7;

constructor(IPoolAddressesProvider provider) Pool(provider) {}

Expand Down
8 changes: 4 additions & 4 deletions src/contracts/interfaces/IPool.sol
Original file line number Diff line number Diff line change
Expand Up @@ -201,12 +201,12 @@ interface IPool {
event MintedToTreasury(address indexed reserve, uint256 amountMinted);

/**
*
* @dev Emitted when deficit is realized on a liquidation.
* @param user The user address where the bad debt will be burned
* @param debtAsset The address of the underlying borrowed asset to be burned
* @param amount The amount to burn
* @param amountCreated The amount of deficit created
*/
event DeficitCreated(address indexed user, address indexed debtAsset, uint256 amount);
event DeficitCreated(address indexed user, address indexed debtAsset, uint256 amountCreated);

/**
* @notice Mints an `amount` of aTokens to the `onBehalfOf`
Expand Down Expand Up @@ -804,7 +804,7 @@ interface IPool {
function deposit(address asset, uint256 amount, address onBehalfOf, uint16 referralCode) external;

/**
* @notice It Covers the deficit of a specified reserve by burning:
* @notice It covers the deficit of a specified reserve by burning:
* - the equivalent aToken `amount` for assets with virtual accounting enabled
* - the equivalent `amount` of underlying for assets with virtual accounting disabled (e.g. GHO)
* @dev The deficit of a reserve can occur due to situations where borrowed assets are not repaid, leading to bad debt.
Expand Down
4 changes: 2 additions & 2 deletions src/contracts/protocol/libraries/logic/LiquidationLogic.sol
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ library LiquidationLogic {
// See `IPool` for descriptions
event ReserveUsedAsCollateralEnabled(address indexed reserve, address indexed user);
event ReserveUsedAsCollateralDisabled(address indexed reserve, address indexed user);
event DeficitCreated(address indexed user, address indexed debtAsset, uint256 amount);
event DeficitCovered(address indexed reserve, address caller, uint256 amountDecreased);
event DeficitCreated(address indexed user, address indexed debtAsset, uint256 amountCreated);
event DeficitCovered(address indexed reserve, address caller, uint256 amountCovered);
event LiquidationCall(
address indexed collateralAsset,
address indexed debtAsset,
Expand Down
5 changes: 0 additions & 5 deletions src/contracts/protocol/libraries/logic/ReserveLogic.sol
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ import {PercentageMath} from '../math/PercentageMath.sol';
import {Errors} from '../helpers/Errors.sol';
import {DataTypes} from '../types/DataTypes.sol';
import {SafeCast} from '../../../dependencies/openzeppelin/contracts/SafeCast.sol';
import {IAToken} from '../../../interfaces/IAToken.sol';
import {UserConfiguration} from '../configuration/UserConfiguration.sol';

/**
* @title ReserveLogic library
Expand All @@ -27,7 +25,6 @@ library ReserveLogic {
using GPv2SafeERC20 for IERC20;
using ReserveLogic for DataTypes.ReserveData;
using ReserveConfiguration for DataTypes.ReserveConfigurationMap;
using UserConfiguration for DataTypes.UserConfigurationMap;

// See `IPool` for descriptions
event ReserveDataUpdated(
Expand All @@ -39,8 +36,6 @@ library ReserveLogic {
uint256 variableBorrowIndex
);

event ReserveUsedAsCollateralDisabled(address indexed reserve, address indexed user);

/**
* @notice Returns the ongoing normalized income for the reserve.
* @dev A value of 1e27 means there is no income. As time passes, the income is accrued
Expand Down
Loading