Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting collections with special characters doesn't work #44

Open
lazka opened this issue Feb 12, 2024 · 2 comments
Open

Deleting collections with special characters doesn't work #44

lazka opened this issue Feb 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@lazka
Copy link

lazka commented Feb 12, 2024

Describe the bug

If I create a collection with a "+" in the name I can no longer interact with it. Deleting, importing etc all fail.

It looks as if there is no escaping happening when building URLs for the typesense API (??)

To Reproduce

  • Add collection
  • Name "foo+bar", add a dummy field
  • Go to the collections list and try to delete the collection
  • There are errors and nothing happens

Expected behavior

  • The collection is deleted

Environment (please complete the following information):

  • Application mode: Desktop
  • OS: [e.g.Windows 11, Linux Ubuntu, MacOS] Linux
  • Browser: [e.g. chrome, firefox, safari] Firefox
  • Version: [e.g. 22] 122
  • Typesense Server version: 0.25.2
@bfritscher
Copy link
Owner

Hi, thanks for reporting.
I can confirm the bug. However, we are using the official https://github.com/typesense/typesense-js sdk to make the api queries in this project. I think this need to be fixed there typesense/typesense-js#194 If it is not, will create workarounds here.

@lazka
Copy link
Author

lazka commented Feb 12, 2024

Oh, I see, thanks for forwarding the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants