You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Olle-Lukowski opened this issue
Nov 15, 2024
· 3 comments
Labels
A-UIGraphical user interfaces, styles, layouts, and widgetsD-TrivialNice and easy! A great choice to get started with BevyS-WontfixThis issue is the result of a deliberate design decision, and will not be fixed
In bevyengine/bevy-website#1782, it was mentioned that the (WIP) migration guide for the text rework (#15591), refers to UiTextWriter instead of the actual name we have right now TextUiWriter.
I think it is obvious how this mistake slipped in there, UiTextWriter is a more intuitive name. It is (in my opinion) better to have a type alias' name have something appended or prepended to the name, instead of plopping something in the middle (like we have right now, where we added Ui in between instead of at the front).
The same thing goes for TextUiReader, I think they should both be renamed.
Let me know what you think, just wanted to ask this before I start writing some stuff for the website.
The text was updated successfully, but these errors were encountered:
Yeah I didn't like the new Text<X>Reader/Writer naming scheme from the PR but didn't feel like it was important enough to fuss over.
Definitely strongly prefer prefixes or suffixes over infixes for name discriminators.
A-UIGraphical user interfaces, styles, layouts, and widgetsD-TrivialNice and easy! A great choice to get started with BevyS-WontfixThis issue is the result of a deliberate design decision, and will not be fixed
In bevyengine/bevy-website#1782, it was mentioned that the (WIP) migration guide for the text rework (#15591), refers to
UiTextWriter
instead of the actual name we have right nowTextUiWriter
.I think it is obvious how this mistake slipped in there,
UiTextWriter
is a more intuitive name. It is (in my opinion) better to have a type alias' name have something appended or prepended to the name, instead of plopping something in the middle (like we have right now, where we addedUi
in between instead of at the front).The same thing goes for
TextUiReader
, I think they should both be renamed.Let me know what you think, just wanted to ask this before I start writing some stuff for the website.
The text was updated successfully, but these errors were encountered: