Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support integration of sonoff devices with MQTT #25

Open
ivanfmartinez opened this issue Mar 11, 2019 · 3 comments
Open

support integration of sonoff devices with MQTT #25

ivanfmartinez opened this issue Mar 11, 2019 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ivanfmartinez
Copy link

  • pySonoffLAN version: 0.2.1
  • Python version: 3.7
  • Operating System: linux

Description

To make easier to integrate with home automation systems, in my case openhab.

What I Did

I have started a gateway using this library.

The code is available here : https://github.com/ivanfmartinez/pysonofflan/blob/mqtt_gateway/sonoff_mqtt.py

Tested with sonoff basic devices. I have one 4CH Pro device that I will integrate after #6 is solved.

Please send suggestions

@beveradb beveradb added enhancement New feature or request help wanted Extra attention is needed labels Apr 29, 2019
@beveradb
Copy link
Owner

Sorry for taking so long to respond to this, I've had a busy month.

This looks awesome, thank you for your contribution!

I'm not sure of what exactly you were looking for from me here, but if you submit that code as a pull request to this project (perhaps with some tests?) I'm happy to review and merge?

@ivanfmartinez
Copy link
Author

I will wait for the #45 merge because I found some problems that are related to this.

After the merge I will make more changes in the code and later send a PR.

@mattsaxon
Copy link
Collaborator

@ivanfmartinez, #45 is merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants