Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating analytics to use build server #3729

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Updating analytics to use build server #3729

merged 3 commits into from
Jan 4, 2024

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Jan 4, 2024

  • allows for server side analytics submission to whatever service we plan to use

@blckmn blckmn added the Cleanup label Jan 4, 2024
@blckmn blckmn added this to the 10.10.0 milestone Jan 4, 2024
@blckmn blckmn self-assigned this Jan 4, 2024
@blckmn
Updating analytics to use build server
878fa9f 
- allows for server side analytics submission to whatever service we plan to use
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member Author

blckmn commented Jan 4, 2024

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

nerdCopter
nerdCopter approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving as nothing seemingly broken; tested flashing FC and configuring.
  • did not inspect the analytics code

haslinghuis
haslinghuis approved these changes Jan 4, 2024
View reviewed changes
src/js/Analytics.js Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

3.5% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit 66d175b into betaflight:master Jan 4, 2024
7 of 8 checks passed
@blckmn blckmn deleted the analytics-patch branch January 7, 2024 18:19
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@blckmn @chmelevskij
Updating analytics to use build server (betaflight#3729)
1130fe8 
* Updating analytics to use build server

- allows for server side analytics submission to whatever service we plan to use

* Revert to const (artifact left over from some testing)

* Send the changeList object in total
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@blckmn blckmn

Labels
Cleanup
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@blckmn @haslinghuis @nerdCopter