Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't dig deep into the project and vendor folders. Just check files in root #3

Open
b3nl opened this issue Mar 30, 2021 · 1 comment · May be fixed by #4
Open

Don't dig deep into the project and vendor folders. Just check files in root #3

b3nl opened this issue Mar 30, 2021 · 1 comment · May be fixed by #4
Assignees
@tkellner
Labels
enhancement New feature or request

Comments

@b3nl
Copy link

b3nl commented Mar 30, 2021

The checker takes a very long time because it checks EVERY folder of a project.
(https://symfony.com/doc/current/components/finder.html#directory-depth)
I Would suggest, that it only checks a depth of one.
@b3nl b3nl added the enhancement New feature or request label Mar 30, 2021
tkellner added a commit that referenced this issue Apr 6, 2021
@tkellner
#3 Adding depth flag to speed up check for large directory trees.
cd29e88
tkellner added a commit that referenced this issue Apr 6, 2021
@tkellner
#3 Adding depth flag to speed up check for large directory trees.
07b0481
@tkellner tkellner linked a pull request Apr 6, 2021 that will close this issue
#3 Adding depth flag to speed up check for large directory trees. #4
Open
@tkellner tkellner self-assigned this Apr 6, 2021
@tkellner
Copy link
Contributor

tkellner commented Apr 6, 2021

I think in general it's not necessary to limit the depth. But I've introduced an option to limit the depth.

b3nl pushed a commit that referenced this issue Apr 6, 2021
#3 WIP
8dbb096 
Signed-off-by: Bjoern Lange <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkellner tkellner

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3 Adding depth flag to speed up check for large directory trees. bestit/license-check
2 participants
@b3nl @tkellner