Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

names-dataset made breaking chnages #8

Closed
bnaman50 opened this issue Sep 13, 2022 · 4 comments
Closed

names-dataset made breaking chnages #8

bnaman50 opened this issue Sep 13, 2022 · 4 comments

Comments

@bnaman50
Copy link

Hey team,

I saw that you are using names-dataset library and sadly, they made some breaking changes and it gives following error when you run the example given in the Readme -
AttributeError: 'NameDataset' object has no attribute 'search_first_name'

On further digging, I found that they have removed the search_first_name method altogether. Now only search method is there.

Could you please update the codebase or maybe specify the library version which included search_first_name method?

Thanks,
Naman

@philipperemy
Copy link

@bnaman50 use names-dataset==2.1. A breaking change happened in the 3.X version.

@philipperemy
Copy link

#9

@berknology
Copy link
Owner

Fixed the issue, please check and let me know if the issue persists. Thanks.

@bnaman50
Copy link
Author

Thanks a lot, @berknology. It is working now.

Naman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants