Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second round of feedback - issues #21

Open
4 tasks
roryspanton opened this issue Sep 23, 2022 · 0 comments
Open
4 tasks

Second round of feedback - issues #21

roryspanton opened this issue Sep 23, 2022 · 0 comments

Comments

@roryspanton
Copy link
Collaborator

Ben - I've been back through the worksheets on the live site since your recent update. As a minor adjustment, I changed a typo and rephrased a sentence for clarity. The major issues I found were to do with videos:

  • No videos are showing for me on the live site since your update. There is just white space where the embedded video should be. I located the iframe for each video in the site's HTML by inspecting it through my browser, but for some reason, they just aren't displaying properly.
  • The Youtube IDs for two videos ("Introducing RMarkdown" in worksheet 1 and "Passing Data with Pipes" in worksheet 2) need to be specified. That is, the code to display these videos in the markdown files for each worksheet currently uses a placeholder ID ( r video("YOUTUBEID") ) and so wouldn't redirect to the right video even if displayed correctly.

Minor comments:

  • Andy Wills should be listed as a co-author on the main site page, given he contributed to the "Getting Started" materials
  • Recommend that your instruction to “place cursor anywhere on the line” to run a code chunk be replaced with “click anywhere on the line” for clarity. Up to you, though.

Hope these make sense - happy to add clarification if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant