Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git clone urls #7

Open
ddnexus opened this issue Jan 13, 2023 · 7 comments
Open

Git clone urls #7

ddnexus opened this issue Jan 13, 2023 · 7 comments

Comments

@ddnexus
Copy link
Collaborator

ddnexus commented Jan 13, 2023

$ git clone --branch bootstrap [email protected]:benkoshy/pagy-rails.git

[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Shouldn't the URL be simply https://github.com/benkoshy/pagy-rails.git ?

@benkoshy
Copy link
Owner

I'll check and revert on the 24th of Jan

@benkoshy
Copy link
Owner

Hi Domizio (@ddnexus)

Apologies for the delay:

There are two protocols which can be used to clone: SSH and https.

Can you confirm the the following does not work:

  1. https: git clone https://github.com/benkoshy/pagy-rails.git
  2. ssh: git clone [email protected]:benkoshy/pagy-rails.git

If ssh does not work, then perhaps this might be the solution?

https://docs.github.com/en/authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent

If you could confirm on your end that would be appreciated.

@ddnexus
Copy link
Collaborator Author

ddnexus commented Jan 25, 2023

I always use https because I use different and new created docker containers to clone and try other repos, so I never need ssh for virtual tries.

Admittedly my question was not clear: let me rephrase it.

Do you really want to impose the use of ssh to a user just to clone a public demo? Shouldn't that be as accessible as possible? That is a nuisance in my case because I had to manually do it with https.

However if you think that someone would find ssh more desirable, maybe you could write both.

@benkoshy
Copy link
Owner

Both should work. Thx for clarifying. Will get to the bottom of this.

@benkoshy
Copy link
Owner

benkoshy commented Jan 26, 2023

git clone https://github.com/benkoshy/pagy-rails.git

I tried this one three different computers, linux, windows x2 and could not reproduce the issue: all them seemed to work fine with https.

perhaps i'm misunderstanding the issue? any ideas?

@ddnexus
Copy link
Collaborator Author

ddnexus commented Jan 26, 2023

Indeed the issue is ssh, not https. 🙂

@benkoshy
Copy link
Owner

benkoshy commented Mar 6, 2023

I've switched to https in the readme. That should solve 99% of the problems, i think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants