Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to upload video when bucket name contains dots eg. domain names #90

Open
tomasz-konecki opened this issue Aug 30, 2019 · 0 comments

Comments

@tomasz-konecki
Copy link

tomasz-konecki commented Aug 30, 2019

Hi,

First of all, I would like to say that I appreciate your effort to create this library.
After some time of using it in my react native application, I noticed that occasional problems occurred while uploading videos to the server. It turned out to be due to the structure of the url variable in the RNS3.js file.

I changed the original structure:

var url =
  "http://" +
  options.bucket +
  "." +
  (options.awsUrl || AWS_DEFAULT_S3_HOST);

to:

var url = `https://s3.${options.region}.amazonaws.com/${options.bucket}/`;

and now it is working without any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant