Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images (and generic Webpack assets) #18

Open
benglynn opened this issue Jul 31, 2020 · 0 comments
Open

Images (and generic Webpack assets) #18

benglynn opened this issue Jul 31, 2020 · 0 comments

Comments

@benglynn
Copy link
Owner

Allow markdown to reference images. Use scan to create variants with a site-wide spec.

This is likely to break down into three related tasks:

image dependencies

A page-pipe pipeable. Glean from markdown metadata and content. Changes to any image source then trigger a render.

Image versions

  • Part of the render pipeline as we don't want to do this work unnecessarily. Generate Buffer for each image variant.
  • This is destined to be emitted much like html, perhaps a generic assets would mean tapAsyncCallback is better encapsulated?
  • Related to the previous point, why is Webpack 'hidden' from CompileContext? Perhaps address that here, the webackReducer can always be stubbed in tests

figure

Client code to enhance the low-res variant in source to a responsive image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant