Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize inputs #9

Open
immortalx opened this issue Jul 11, 2018 · 4 comments
Open

Sanitize inputs #9

immortalx opened this issue Jul 11, 2018 · 4 comments

Comments

@immortalx
Copy link

Does yup or something else you are using sanitizes the user inputs?
I'm using https://github.com/leizongmin/js-xss and it works very well.

@benawad
Copy link
Owner

benawad commented Jul 11, 2018

I believe react does

@immortalx
Copy link
Author

Even if react does, the api should take care of it since it can be consumed by other clients. Again, i'm not sure if yup or even if typeorm does this but it's a fair concern for a production ready system.

@benawad
Copy link
Owner

benawad commented Jul 11, 2018

yeah it's worth doing if there are other clients that don't use react

@immortalx
Copy link
Author

This article is from 2016 https://medium.com/node-security/the-most-common-xss-vulnerability-in-react-js-applications-2bdffbcc1fa0
It seems it affects mostly SSR apps.
Anyway it was just a concern i had and i actually do it in my api, but i don't use yup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants