Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative lock store (git, S3, etc.) #11

Open
prein opened this issue Mar 11, 2023 · 2 comments
Open

Alternative lock store (git, S3, etc.) #11

prein opened this issue Mar 11, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@prein
Copy link

prein commented Mar 11, 2023

Would it be hard to make it an option to use either git or s3 (or other) for storing the lock files?

@ben-z
Copy link
Owner

ben-z commented Mar 11, 2023

Git should be doable and only requires lines like this to be changed:

__repo_url="https://x-access-token:$ARG_REPO_TOKEN@github.com/$ARG_REPOSITORY"

S3 is a completely different mechanism and would require a lot more work.

Though personally I don’t need both use cases and would rely on external contribution and testing :)

@ben-z ben-z added the help wanted Extra attention is needed label Dec 12, 2023
@ben-z ben-z changed the title Option to use S3 as lock store Alternative lock store (git, S3, etc.) Dec 12, 2023
@ben-z
Copy link
Owner

ben-z commented Dec 12, 2023

Quick thought: Terraform's S3 backend relies on DynamoDB for locking. Perhaps S3 doesn't have the facilities to support atomic locking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants