-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a configuration window on the UI #2
Comments
https://caniuse.com/?search=dialog Will impact the browser versions, but probably the best option. Let me know if you're okay with it and I'll shoot in a PR |
Dialogs have been implemented already for the weather and shortcuts modal, so no problem in using them. If you want to have a go at it, be my guest! Although the architecture should be fairly straightforward, I'll just leave a couple of notes:
|
New method that exposes supported languages has been added, see PR#3 |
Late to the party, but want to definitely +1 this issue. Some suggestions on the different layers of configuration. There could be a top level configuration of number of screens and their respective types. Then each screen could be populated with a drop-down allowing users to switch between supported types for which an API key exists. If you are still interested @roberrrt-s, I can formally assign you! |
Sounds like a plan, I'll schedule some work to do in a week (10th of Sept) since I'm covered in deadlines until then. |
The configuration module already supports read and write from sessionStorage and localStorage. A dialog modal could be added on the frontend to let users configure Avoc directly on the UI instead of relying solely on the configuration.js file.
The text was updated successfully, but these errors were encountered: