Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] purchase_order_responsible #525

Merged
merged 9 commits into from
Dec 15, 2023
Merged

[16.0][MIG] purchase_order_responsible #525

merged 9 commits into from
Dec 15, 2023

Conversation

carmenbianca
Copy link
Collaborator

Description

Odoo task (if applicable)

https://gestion.coopiteasy.be/web#id=11104&action=475&active_id=492&model=project.task&view_type=form&menu_id=

Checklist before approval

  • Tests are present (or not needed).
  • Credits/copyright have been changed correctly.
  • Change log snippet is present.
  • (If a new module) Moving this to OCA has been considered.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023 •
edited
Loading

Codecov Report

Merging #525 (dd44ca7) into 16.0 (4803b52) will decrease coverage by 0.17%.
The diff coverage is 52.63%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             16.0     #525      +/-   ##
==========================================
- Coverage   66.26%   66.10%   -0.17%     
==========================================
  Files          45       48       +3     
  Lines        1592     1611      +19     
  Branches      217      222       +5     
==========================================
+ Hits         1055     1065      +10     
- Misses        495      504       +9     
  Partials       42       42
Files Changed Coverage Δ
purchase_order_responsible/models/purchase.py 47.05% <47.05%> (ø)
purchase_order_responsible/__init__.py 100.00% <100.00%> (ø)
purchase_order_responsible/models/__init__.py 100.00% <100.00%> (ø)

victor-champonnois
victor-champonnois approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@victor-champonnois victor-champonnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK

  • set responsible replaces the create_uid field : OK
  • replace the mail_follower : OK
  • adds the referent name in the purchase order pdf report : OK

victor-champonnois
victor-champonnois reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@victor-champonnois victor-champonnois left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK (just a comment on a formulation)

purchase_order_responsible/views/purchase_order.xml
<filter name="my_purchases" position="after">
<filter
name="my_responsible"
string="My Responsible"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"My responsible" ? Is is a correct formulation ?

robinkeunen
robinkeunen approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@robinkeunen robinkeunen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon this could be submitted to the OCA

@github-grap-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@robinkeunen
Copy link
Member

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-525-by-robinkeunen-bump-nobump, awaiting test results.

github-grap-bot added a commit that referenced this pull request Dec 15, 2023
@github-grap-bot
Merge PR #525 into 16.0
057f876 
Signed-off-by robinkeunen
@github-grap-bot
Copy link
Contributor

@robinkeunen your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-525-by-robinkeunen-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@github-grap-bot
Copy link
Contributor

@robinkeunen your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-525-by-robinkeunen-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@robinkeunen robinkeunen force-pushed the 16.0-mig-purchase_order_responsible branch from dd44ca7 to 62dec0b Compare December 15, 2023 14:19
@robinkeunen
Copy link
Member

/ocabot rebase

@github-grap-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@robinkeunen
Copy link
Member

/ocabot rebase

@victor-champonnois @github-grap-bot
[REF] split beesdoo_purchase
5068f58 
into:
- account_invoice_line_custom_reference
- purchase_order_responsible
- purchase_order_main_supplier

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@github-grap-bot
[UPD] Update purchase_order_responsible.pot
78d2d7e 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@github-grap-bot
[UPD] README.rst
8930e20 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca @github-grap-bot
[IMP] purchase_order_responsible: black, isort, prettier
ec76335
@carmenbianca @github-grap-bot
[MIG] purchase_order_responsible: Migration to 13.0
b4469f9 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca @github-grap-bot
[MIG] purchase_order_responsible: Migration to 14.0
bee432d 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca @github-grap-bot
[MIG] purchase_order_responsible: Migration to 15.0
570ecb1 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca @github-grap-bot
[MIG] purchase_order_responsible: Migration to 16.0
049cc65 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca @github-grap-bot
[FIX] purchase_order_responsible: Dedent entire files
bd53a35 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@github-grap-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@github-grap-bot github-grap-bot force-pushed the 16.0-mig-purchase_order_responsible branch from 62dec0b to bd53a35 Compare December 15, 2023 14:49
@robinkeunen
Copy link
Member

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-525-by-robinkeunen-bump-nobump, awaiting test results.

@github-grap-bot github-grap-bot merged commit 13cb81f into 16.0 Dec 15, 2023
2 checks passed
@github-grap-bot github-grap-bot deleted the 16.0-mig-purchase_order_responsible branch December 15, 2023 16:17
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at a8615b6. Thanks a lot for contributing to beescoop. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victor-champonnois victor-champonnois victor-champonnois approved these changes

@robinkeunen robinkeunen robinkeunen approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carmenbianca @codecov-commenter @github-grap-bot @robinkeunen @victor-champonnois