Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are “seller” and “supplier” used interchangeably in product_main_supplier ? #456

Open
victor-champonnois opened this issue Oct 6, 2022 · 1 comment

Comments

@victor-champonnois
Copy link
Member

# début la plus récente et plus petite qu’aujourd’hui fixme
# could product.main_seller_id be used instead? it seems that
# “seller” and “supplier” are used interchangeably in this
# class. is this on purpose?

@remytms
Copy link
Collaborator

remytms commented Oct 19, 2022

The object that links seller and product in odoo is named supplierinfo. I think that why sometimes one is used instead of another.

The seller_ids field is linked to a product.supplierinfo object. This may have sens since this field is meant to be shown in views. So that Seller is more understandable than supplierinfo.

But in general I prefer to use a field named like the object where it points to. Like main_supplierinfo_id is a good example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants