Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#325 refactor workflow flow #346

Closed
wants to merge 7 commits into from

Conversation

obr42
Copy link
Contributor

@obr42 obr42 commented Apr 13, 2023

Closes #325

Refactor workflow pages. This involved combining some files and re-naming others. Keep the create workflow modal, but when editing a workflow there is no modal. There is now a page that allows for changing name/description while also adding steps/params. The workflow detail page allows for param input and executing workflow, and lists workflow steps in a concise way in case user needs reminding.

Add toast notifications for add/remove/edit step and params. This is helpful to let user know modifications are "saved" and it is safe to navigate away from page, since save button is for name/description only. Code added for success, warning, info, error toasts - can now be used for any HTMX return by adding the following to the HttpResponse or HttpResponseClientRedirect:

            headers={
                "HX-Trigger": json.dumps(
                    {
                        "showMessages": [{
                            "level": "success", // or info, warning, danger
                            "msg": "My alert.",
                        }]
                    }
                ),
            },

On edit/create view, confirm deletion of steps/params prior to actually deleting them.

Removed unused ui/urls.py definitions: all-variables, variable-detail, workflow-delete. Removed some unused CSS classes. Added class to set min width on step move column, so buttons wouldn't overlap when there are two steps and a small width.

Fixed bug on Task Detail page where the name was not showing properly.

@obr42 obr42 marked this pull request as ready for review April 17, 2023 19:20
@obr42 obr42 marked this pull request as draft April 18, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor workflow flow
2 participants