Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor workflow flow #325

Open
5 tasks done
Tracked by #238
obr42 opened this issue Apr 6, 2023 · 2 comments
Open
5 tasks done
Tracked by #238

Refactor workflow flow #325

obr42 opened this issue Apr 6, 2023 · 2 comments
Assignees
Labels
ui Related to the UI

Comments

@obr42
Copy link
Contributor

obr42 commented Apr 6, 2023

  • Get rid of modal, instead edit name/description directly in main page
  • "Workflow updated" toast
  • Confirm delete of Parameters and Steps
  • Archive workflow from table (same button as Schedules table actions button) moved to schedule & WF table menu button #341
  • if you have 2 steps in your workflow and your browser is wide, the "move up" arrow is aligned like 3 pixels to the left of the "move down" arrow. They're aligned if you open the dev tools and it the CSS switches to less wide
@obr42 obr42 added the ui Related to the UI label Apr 6, 2023
@obr42 obr42 mentioned this issue Apr 6, 2023
58 tasks
@obr42 obr42 self-assigned this Apr 12, 2023
obr42 added a commit to obr42/functionary that referenced this issue Apr 13, 2023
obr42 added a commit to obr42/functionary that referenced this issue Apr 14, 2023
obr42 added a commit to obr42/functionary that referenced this issue Apr 14, 2023
obr42 added a commit to obr42/functionary that referenced this issue Apr 17, 2023
@obr42
Copy link
Contributor Author

obr42 commented Apr 18, 2023

BUG:

  • Create workflow button is doing HTMX and not updating the URL so browser back  button doesn't work

IMPROVEMENTS:

  • Switch back to modal for name/descrip since we need to have the ID to add, like having ability to "cancel the create"
  • Move add/edit step/param toast to returning on page re-load, instead of returning on the post call
  • Toast message: "Workflow saved."
  • Save trigger toast, no page change
  • Make steps inline and above the param input
  • More tweaks to the step move buttons so they don't feel so far apart when just two steps
  • Push section contents to left edge, but keep buttons aligned
  • Use more horizontal space on the edit page, try to not have it pushed down so much
    • Tables more wide
    • cut down margin on bordered box
    • cut down space between label and input
    • Shrink step/param headers a bit in font size
  • Inline steps tooltip > popover so can use cube icon

UNRELATED BUG:

  • workflow tasking breadcrumb doesn't show name

@obr42
Copy link
Contributor Author

obr42 commented Apr 18, 2023

Image

obr42 added a commit to obr42/functionary that referenced this issue Apr 18, 2023
obr42 added a commit to obr42/functionary that referenced this issue Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Related to the UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant