Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If tmin is negative, treat it as relative to now #276

Open
1 of 2 tasks
dreeves opened this issue Sep 6, 2022 · 2 comments
Open
1 of 2 tasks

If tmin is negative, treat it as relative to now #276

dreeves opened this issue Sep 6, 2022 · 2 comments
Assignees
Labels
ADO Question / what to Actually Do / much ado... PEA Easy-peasy RFE Request For Enhancement UVI

Comments

@dreeves
Copy link
Member

dreeves commented Sep 6, 2022

Desiderata

Preview Give feedback

Madge in Discord: Feature request: make the x-axis able to show eg "the past year" as opposed to either custom date or all data as some of my graphs I don't like getting too big and updating is annoying

Cognata

Verbata: relative tmin, t-min, xmin, x-min, anti-magic?, magic strings, hms parsafore,

@dreeves dreeves added RFE Request For Enhancement PEA Easy-peasy UVI labels Sep 6, 2022
@dreeves
Copy link
Member Author

dreeves commented Sep 6, 2022

Wait, I guess tmin is passed as a daystamp like "2022-09-06" so there's no such thing as "if it's negative". I guess we need special syntax like "now-14d" or something? I do have javascript code handy for parsing amounts of time like that, namely my HMS Parsafore library.

@dreeves dreeves added the ADO Question / what to Actually Do / much ado... label Jan 1, 2024
@dreeves dreeves self-assigned this Jan 1, 2024
@dreeves
Copy link
Member Author

dreeves commented Aug 27, 2024

Update: Thanks to gbear605 for pointing out that there's an ISO standard for relative date/time. But also we're just handling the logic for this in Beebody so Beebrain can just continue to always get an absolute daystamp. If the user opts for relative tmin (aka x-min) then Beebody does the math and sends the dynamically computed absolute tmin each time it asks Beebrain for the graph.

Meaning there's nothing for Beebrain to do here, at the moment.

But maybe in the future we could decide it's cleaner to let Beebody pass along whatever the user opted for -- absolute or relative tmin -- and let Beebrain handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADO Question / what to Actually Do / much ado... PEA Easy-peasy RFE Request For Enhancement UVI
Projects
None yet
Development

No branches or pull requests

1 participant