Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible floating point error with skatesum #250

Open
2 tasks
bsoule opened this issue Feb 18, 2022 · 0 comments
Open
2 tasks

Possible floating point error with skatesum #250

bsoule opened this issue Feb 18, 2022 · 0 comments
Labels
ADO Question / what to Actually Do / much ado... BUG UVI

Comments

@bsoule
Copy link
Member

bsoule commented Feb 18, 2022

Desiderata

Preview Give feedback
  1. A user has a goal with aggday = skatesum.
  2. Daily rate of the red line is 0.03 or possibly 0.0299999999999 because floating point.
  3. There's a datapoint for Feb 15 that's greater than the daily rate, specifically 0.04583333333333333.
  4. It's submitted well before the deadline.
  5. When the goal is brained for the deadline, it derails.

It appears that when Beebrain is agging the data and subbing in the daily rate for the actual datapoint value (since actual datapoint value is higher than daily rate), there is some floating point error happening, causing the goal to derail despite that it ought to be safe.

Sample bb file: skatesum_floating_point.bb

(This is arguably a worse-than-baneful bug but it's like a corner case of a corner case. I think.)

Cognata

Verbata: floating point hell, baneful bugs, aggday skatesum,

@dreeves dreeves changed the title possible floating point error with skatesum Possible floating point error with skatesum Feb 26, 2022
@dreeves dreeves added ADO Question / what to Actually Do / much ado... BUG UVI labels Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADO Question / what to Actually Do / much ado... BUG UVI
Projects
None yet
Development

No branches or pull requests

2 participants