Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inferred vmin (y-min) is off after a long flatline #234

Open
1 task
bsoule opened this issue Sep 10, 2021 · 0 comments
Open
1 task

Inferred vmin (y-min) is off after a long flatline #234

bsoule opened this issue Sep 10, 2021 · 0 comments

Comments

@bsoule
Copy link
Member

bsoule commented Sep 10, 2021

Desiderata

Preview Give feedback

Beebrain is making a questionable choice for the inferred vmin (aka y-min) with this graph, cutting the red line off from sight. Basic description of the goal in question:

  1. There is no data between tmin and today - 1
  2. The red line slope is zero between tmin and the akrasia horizon
  3. There is one datapoint for today
  4. The value of the red line is 30, the agg'd data for today is 31
  5. Beebrain picks 31 for the vmin

The bb file bad-inferred-vmin.bb in privatesuite shows the state with the red line cut off. If you add a 0 datapoint to yesterday -- as in the 2nd screenshot below -- then Beebrain picks vmin including the red line. If you add the explicit zero to today, it still cuts the red line out. If you remove the datapoint for today (asof), then the vmin choice includes the red line.

This might be a regression from the recent changes with how flatlining works? Or it could have been here all along.

image

image

Verbata: graph aesthetics, choice of zoom window, tmin, vmin, t-min, v-min,

@dreeves dreeves changed the title Inferred v-min is off after a long flatline Inferred vmin (y-min) is off after a long flatline Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants