You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Currently the allowance is hard coded to 8000000000 'ether' [1]; user can manually override this in their wallet.
Ideally user could choose to allow an amount equal to their deposit, or allow unlimited (á la 1inch). Hard coding to unlimited would be helpful in the short term.
Either way; the DepositSection should check if the allowance is greater than the amount to be deposited; rather the current check of greater than 0 [2][3][4].
Currently the allowance is hard coded to 8000000000 'ether' [1]; user can manually override this in their wallet.
Ideally user could choose to allow an amount equal to their deposit, or allow unlimited (á la 1inch). Hard coding to unlimited would be helpful in the short term.
Either way; the DepositSection should check if the allowance is greater than the amount to be deposited; rather the current check of greater than 0 [2][3][4].
[1]
beefy-app/src/features/web3/approval.js
Line 10 in e1e4f0b
[2]
beefy-app/src/features/vault/components/PoolDetails/DepositSection/DepositSection.js
Lines 67 to 69 in e1e4f0b
[3]
beefy-app/src/features/vault/components/PoolDetails/DepositSection/DepositSection.js
Line 96 in e1e4f0b
[4]
beefy-app/src/features/vault/components/PoolDetails/DepositSection/DepositSection.js
Line 132 in e1e4f0b
The text was updated successfully, but these errors were encountered: