Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain tests fail on windows #301

Closed
toothsy opened this issue Mar 23, 2023 · 4 comments
Closed

Certain tests fail on windows #301

toothsy opened this issue Mar 23, 2023 · 4 comments
Labels
bug Something isn't working high priority High priority - something is broken or missing that is critical for users or developers. intermediate Will take some time to fix stale windows Issues that are specific to Windows clients.
Milestone

Comments

@toothsy
Copy link
Contributor

toothsy commented Mar 23, 2023

Describe the bug
Hello,I'm a windows user and I cloned the repo locally, installed all the vscode extensions, and ran all the tests, some test cases failed

To Reproduce
Steps to reproduce the behavior:

  1. have a windows Operating system
  2. clone the repo locally
  3. run it in VSC
  4. run all tests

Expected behavior
all tests must be green but some failed

Screenshots
image

Desktop:

  • OS: [Windows]

Additional context
upon closer inspection in gff_test.go

  • image
    • atoiFn is getting "6370\r" as its input hence it is panics
  • the newline error due to windows is causing the issue
@carreter
Copy link
Collaborator

Once #340 is merged, this will be an easy fix.

@carreter
Copy link
Collaborator

carreter commented Sep 12, 2023

Also @toothsy could you inspect the data being read in by the tests and let us know what the line endings are on Windows? You can do this using git ls-files --eol, please post the output of that here. Would do it myself but I don't have a Windows computer.

@carreter carreter added bug Something isn't working windows Issues that are specific to Windows clients. high priority High priority - something is broken or missing that is critical for users or developers. intermediate Will take some time to fix labels Sep 16, 2023
@carreter carreter added this to the v1.0 milestone Sep 23, 2023
@carreter carreter moved this from Todo to In Progress in poly development roadmap Sep 23, 2023
@carreter carreter moved this from In Progress to Todo in poly development roadmap Sep 23, 2023
@carreter
Copy link
Collaborator

Bumping this. If anyone has access to a Windows machine, info would be greatly appreciated! Worst case I can spin up a VM, but I'm lazy...

Copy link

github-actions bot commented Dec 1, 2023

This issue has had no activity in the past 2 months. Marking as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority High priority - something is broken or missing that is critical for users or developers. intermediate Will take some time to fix stale windows Issues that are specific to Windows clients.
Projects
None yet
Development

No branches or pull requests

3 participants