Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beat and Bar Encoding in Transformer Encoder Question #20

Open
chaonan99 opened this issue Feb 21, 2020 · 1 comment
Open

Beat and Bar Encoding in Transformer Encoder Question #20

chaonan99 opened this issue Feb 21, 2020 · 1 comment

Comments

@chaonan99
Copy link

Hi, this line of code seems redundant since bar_pos is already < self.max_bar_len by the line above.

Also I am a little bit confused about the default value of beat_len=32 and max_bar_len=1024. beat_len=4 makes more sense in my opinion since the value will loop every quarter note. Could you please give me more details?

@ColtonOsterlund
Copy link

Hello @chaonan99 @bearpelican, I am wondering the same thing. Did you ever come to a conclusion for the beat_len=32 and the max_bar_len=1024 values?
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants