Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to pass literal false into shortcode parameters #11

Open
kevinlangleyjr opened this issue Aug 6, 2015 · 0 comments
Open

No way to pass literal false into shortcode parameters #11

kevinlangleyjr opened this issue Aug 6, 2015 · 0 comments

Comments

@kevinlangleyjr
Copy link

Unfortunately, when you pass false as an parameter within a shortcode, it is not a literal false but is instead a string of "false". But here, https://github.com/bearded-avenger/wp-live-search/blob/master/public/includes/class.shortcode.php#L53 you are checking for a literal false which is just impossible since it is provided via a shortcode attribute.

I would love it if all of the logic here was actually separated out from the shortcode handler and the shortcode handler just called the template function instead of vice versa. The template function that is provided has very limited attributes that are able to be set in comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant