Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering account trees in Fava 1.25+ #1721

Closed
redstreet opened this issue Dec 14, 2023 · 3 comments
Closed

Rendering account trees in Fava 1.25+ #1721

redstreet opened this issue Dec 14, 2023 · 3 comments
Labels
duplicate extension Features or enhancements that have Fava extensions or could be implemented as one.

Comments

@redstreet
Copy link
Contributor

redstreet commented Dec 14, 2023

Fava Investor's asset allocation page looked like this. To accommodate the changes in Fava 1.25 onwards, I tried to make these changes. However, this is the result:

Old:
image

New:
image

If you or anybody could provide guidance, tips, or pointers on how to approach changing the Investor.html code based on Fava's changes in this area, it would be most appreciated. Thank you!

@iamkroot
Copy link

iamkroot commented Dec 27, 2023

Also hit this when using tree table.

From what I can tell, the <tree-table> tag is no longer valid, and we need to use the TreeTable svelte component somehow. Example: this is the new source for rendering the Balance Sheet page: https://github.com/beancount/fava/blob/main/frontend/src/reports/tree_reports/BalanceSheet.svelte

I have absolutely zero idea how this works for those of us building plugins without a svelte toolchain.

Paging @yagebu for guidance

@yagebu yagebu added duplicate extension Features or enhancements that have Fava extensions or could be implemented as one. labels Jan 6, 2024
@yagebu
Copy link
Member

yagebu commented Jan 6, 2024

Thanks for reporting this - this is also basically a duplicate of #1695, so I'll close this one here - I'll re-add the now unused CSS and JS so that extensions like fava_investor can work unchanged for now. Let's track how extensions could use the "new" tree tables in the other issue.

@yagebu yagebu closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2024
@redstreet
Copy link
Contributor Author

Sounds great, thanks much @yagebu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate extension Features or enhancements that have Fava extensions or could be implemented as one.
Projects
None yet
Development

No branches or pull requests

3 participants