-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend matchers and refactor #7
Comments
All, 1., 2. and 4. sound great, I have nothing to add there.
Your changes are very welcome! |
Regarding def to_have_attribute(self, key: str):
...
def to_have_attribute(self, key: str, value: Any):
...
def to_have_attributes(self, *keys: str):
... An explanation of |
Both sound great! Looking forward to the PR(s)! |
@petereon Before I get started, one more question, is there a reason why you split alias and negated test into separate methods? Example:
|
@bdsoha Yes, it's for legacy reasons, there have previously been separate implementations for negated matchers. Aliases don't necessarily make sense, I agree. As it is it would presumably make more sense to test just the |
I would like to propose a few additions and refactors (with your approval, I can begin working on them):
The text was updated successfully, but these errors were encountered: