Improve web request handling #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hold State Requests
Pull request #1334 introduced a new screen during the Hold state that only allows you to Resume or Stop the current job.
This PR reverts back to the previous behavior which will allowed it to serve up file requests when
inMotionState()is false, even in Hold state.This is in agreement to the screen that shows when in motion, that appears to say that issuing a feedhold is recommended to be able to reload the WebUI.
304 responses
This PR also adds a check when in motion that will return a 304 when the correct ETag is received and the hash of the file is already cached in memory.
This should reduce the amount of times that the cut down UI is seen if the file needs to be retrieved again for some reason.