Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

justName with $ref definition may be unexpected #645

Open
JounQin opened this issue Nov 28, 2024 · 0 comments
Open

justName with $ref definition may be unexpected #645

JounQin opened this issue Nov 28, 2024 · 0 comments

Comments

@JounQin
Copy link

JounQin commented Nov 28, 2024

schema.$id = toSafeString(justName(dereferencedName))

In our case, dereferencedName could be #/definitions/v1.ManagedFieldsEntry, it's not a filename but internal reference name, but justName consider it as filename always, it should consider # character actually. Currently, it returns v1 but should be v1.ManagedFieldsEntry or ManagedFieldsEntry, right?

Proposal:

/**
* Eg. `foo/bar/baz.json` => `baz`
*/
export function justName(filename = ''): string {
return stripExtension(basename(filename))
}

export function justName(filename = ''): string { 
  return filename.includes('#') ? basename(filename) : stripExtension(basename(filename)) 
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant