Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specify version for changedetector requirement #24

Open
smnorris opened this issue Sep 20, 2024 · 1 comment
Open

specify version for changedetector requirement #24

smnorris opened this issue Sep 20, 2024 · 1 comment

Comments

@smnorris
Copy link
Collaborator

This tool currently pulls the latest (with git) as specified in requirements.txt / pyproject.toml, consider specifying a version for stability.
@smnorris
Copy link
Collaborator Author

smnorris commented Sep 27, 2024 •
edited
Loading

Note current workaround - since the FIT_opendatadownloader image will only include FIT_changedetector that was available when the FIT_opendatadownloader image was built, upgrade to latest FIT_changedetector on every test run https://github.com/bcgov/FIT_opendatadownloader/blob/main/.github/workflows/test.yaml#L38 (if image rebuild is not triggered before a scheduled run, the scheduled run will use the existing image and any changes to main in FIT_changedetector will have no effect)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smnorris