Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Leaflet 1.x #12

Closed
BartWaardenburg opened this issue Oct 3, 2016 · 3 comments
Closed

Compatibility with Leaflet 1.x #12

BartWaardenburg opened this issue Oct 3, 2016 · 3 comments

Comments

@BartWaardenburg
Copy link
Contributor

It seems that updating leaflet to any of the Leaflet 1.x versions will brake this plugin.

It would be really great if someone would be able to find where it breaks and how we can make this compatible again. I'll try to have a look as well.

@bbecquet
Copy link
Owner

bbecquet commented Oct 3, 2016

I'll have a look tonight. I need to check all my plugins for compatibility with 1.0 anyway :) Thanks for reporting!

@bbecquet
Copy link
Owner

bbecquet commented Oct 3, 2016

Hi. I've done some tests with Leaflet 1.0.1 and updated the three examples to use this version. Everything works fine for me, as it was before with the beta and the RC.

But maybe I've overlooked something. If you still experience problems, can you please describe where and how it fails? Console log at minimum, and if you can isolate the problem, please include the code causing it.

@BartWaardenburg
Copy link
Contributor Author

I had the time to look further into it and it seems the hacky fix for #1 seemed to cause it. Looking for a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants