Add provisional support for ADM and other audio metadata RIFF chunks in MXF #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support Wave -> MXF in raw2bmx Support MXF -> Wave in bmxtranswrap
Co-authored-by: thomasheritage <[email protected]>
A single track source package can have a single file descriptor that is not a multiple descriptor.
If there are ADM properties then they will fail to be set and the error message questions whether 'chunk_id' is missing. This also fixes test which wasn't creating a ADMSoundfieldGroupLabelSubDescriptor and was therefore missing a RIFFChunkStreamID_link2 that was mapped from the chunk_id.
* Fix some typos * Re-word for clarity * Update to match latest functionality * ❓ is used in some areas requiring confirmation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds provisional support for the SMPTE ST 2131 CD "Mapping Audio Definition Model (ADM) and other audio metadata RIFF Chunks to MXF" . More details on what is implemented can be found in
docs/audio_definition_model.md. It also provides minimal reading support for MGA / S-ADM.