Changes to improve RDD 44 compliance #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMPTE RDD 44 (RDD 36 / ProRes in MXF) requires SMPTE ST 379-2 (MXF contrained generic container) which requires the ContainerConstraintsSubDescriptor to be included in the file.
It was wrongly set to -1 which indicates that the Temporal Offset property in the index array is used to indicate temporal differences. This commit fixes it to be 0 which indicates there is no temporal reordering.
Was factored out of UncCDCIMXFDescriptorHelper and UncRGBAMXFDescriptorHelper. This allows VideoLineMap to be initialised from input file descriptors in other descriptor helpers.
This was referenced Aug 16, 2023
RDD 44:2022 revised the stored dimensions to not be a multiple of the macro block size as is suggested by ST 377-1 section G.1.1
Separate index and essence body partitions were used despite the OP1A_BODY_PARTITIONS_FLAVOUR flag being set. This change fixes that.
philipnbbc
force-pushed
the
philipn-rdd44-compliance
branch
from
27d84a3 to
56afacb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes that improves RDD 44 (RDD 36 / ProRes in MXF) compliance:
--st379-2option to signal compliance with ST 379-2 for files that may not contain RDD 36. All files created by bmx should be ST 379-2 compliant.--video-line-mapoption to set or override the Video Line Map descriptor property1,0for (FULL_FRAME) progressive video and1,<height/2 + 1>for interlaced--transfer-ch,--coding-eq,--color-prim,--signal-std,-a(aspect ratio) and--color-siting--body-part(OP1A_BODY_PARTITIONS_FLAVOUR define) to include index table segments in the next essence body partition (or footer partition) rather than in a separate partitionRequires BBC-archive/libMXF#5 and BBC-archive/libMXFpp#6
Fixes #24