Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed load() call for pip_deps in WORKSPACE described in README #1653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MattTannahill
Copy link

After setting up my WORKSPACE as described in README.md, I received the error:

Error: file '@io_bazel_rules_docker//repositories:pip_repositories.bzl' does not contain symbol 'io_bazel_rules_docker_pip_deps'

This was fixed by changing the requested symbol to pip_deps.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MattTannahill
To complete the pull request process, please assign smukherj1 after the PR has been reviewed.
You can assign the PR to them by writing /assign @smukherj1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from rubensf October 18, 2020 13:28
@google-cla
Copy link

google-cla bot commented Oct 18, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@MattTannahill
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 18, 2020
@MattTannahill
Copy link
Author

/assign @smukherj1

@MattTannahill
Copy link
Author

MattTannahill commented Oct 18, 2020

After looking into this a bit more closely, it looks like the name of the symbol was changed since release 0.14.4. The correction is valid for the release used in the docs, but will need to be updated again in the next release unless the symbol is changed back to pip_deps.

In version: 0.14.4:

In master:

def io_bazel_rules_docker_pip_deps():

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants