Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.apple.developer.pass-type-identifiers entitlement is replaced by <team-id>.<bundle-id> no matter what #2551

Open
vakhidbetrakhmadov opened this issue Oct 8, 2024 · 2 comments · Fixed by revolut-mobile/rules_apple#8

Comments

@vakhidbetrakhmadov
Copy link
Contributor

vakhidbetrakhmadov commented Oct 8, 2024

Hello,

I am migrating a project from Xcode to Bazel.

When comparing .entitlements in the signature of the .app bundle built with Xcode and with Bazel, i have noticed the following diff:

   "com.apple.developer.pass-type-identifiers" => [
-    0 => "FOOBARBAZ1.*"
+    0 => "FOOBARBAZ1.com.foo.bar"
   ]

I have prepared a branch from master where this can be reproduced.

Please checkout repro pass-type-identifiers, run bazelisk test //test/starlark_tests:ios_application_entitlements_contents_device_test and observe test.log

exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //test/starlark_tests:ios_application_entitlements_contents_device_test
-----------------------------------------------------------------------------
ERROR: Expected 'Array { FOOBARBAZ1.com.google.example }' to match 'Array { FOOBARBAZ1.* }' for key com.apple.developer.pass-type-identifiers
Actual contents were:
Dict {
    application-identifier = FOOBARBAZ1.*
    test-an-entitlement = false
    get-task-allow = true
    com.apple.developer.pass-type-identifiers = Array {
        FOOBARBAZ1.com.google.example
    }
}
@vakhidbetrakhmadov
Copy link
Contributor Author

vakhidbetrakhmadov commented Oct 8, 2024

This seems to be the reason:
https://github.com/bazelbuild/rules_apple/blob/master/tools/plisttool/plisttool.py#L1121-L1125

Does somebody know why it's needed ?

Seems like it was there since the day one of rules_apple - 0bfb9bd#r147706845 (filter files by entitlements.bzl and tap expand all lines to see the comment marking the line).

@vakhidbetrakhmadov
Copy link
Contributor Author

Given the com.apple.developer.pass-type-identifiers entitlement description, current behaviour doesn't seem correct ? 🤔

Screenshot 2024-10-08 at 15 22 06

https://developer.apple.com/documentation/bundleresources/entitlements/com_apple_developer_pass-type-identifiers

vakhidbetrakhmadov added a commit to vakhidbetrakhmadov/rules_apple that referenced this issue Oct 8, 2024
acecilia pushed a commit to revolut-mobile/rules_apple that referenced this issue Oct 8, 2024
acecilia pushed a commit to revolut-mobile/rules_apple that referenced this issue Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant