Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up go fmt, go vet and lint to run as part of presubmit #53

Open
ola-rozenfeld opened this issue Jul 16, 2019 · 1 comment
Open

Set up go fmt, go vet and lint to run as part of presubmit #53

ola-rozenfeld opened this issue Jul 16, 2019 · 1 comment
Assignees
@ifoox
Labels
type: process WIP work in progress

Comments

@ola-rozenfeld
Copy link
Contributor

No description provided.

@ola-rozenfeld ola-rozenfeld self-assigned this Jul 16, 2019
@ifoox ifoox assigned ifoox and unassigned ola-rozenfeld Jul 25, 2019
@ifoox ifoox mentioned this issue Jul 25, 2019
Merged
ola-rozenfeld pushed a commit to ola-rozenfeld/remote-apis-sdks that referenced this issue Jul 26, 2019
Adding lint check to presubmit. Closes bazelbuild#53
f934566
@ola-rozenfeld ola-rozenfeld changed the title Set up go fmt and lint to run as part of presubmit Set up go fmt, go vet and lint to run as part of presubmit Sep 27, 2019
@ola-rozenfeld
Copy link
Contributor Author

Go vet is a good thing as well, it has some practices that lint misses.

@ola-rozenfeld ola-rozenfeld added the WIP work in progress label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ifoox ifoox

Labels
type: process WIP work in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ifoox @ola-rozenfeld