You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Introduce optional node properties specification throughout the rexec client layer, starting with adding it to the command proto:
message InputSpec {
...
map<string,NodeProperties> input_node_properties = 7;
}
// Either copied from [RE-API](https://github.com/bazelbuild/remote-apis/blob/main/build/bazel/remote/execution/v2/remote_execution.proto#L852) or introduce a proto dependency on it
message NodeProperties {
...
}
Problem
Node properties are a (relatively recent) part of the RE-API which is relied upon by Bazel's persistent remote workers feature: https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/remote/merkletree/MerkleTree.java#L398
Bazel uses this to "mark" some files as tools that should persist on the remote worker. This is used by RE implementations (definitely by EngFlow, unsure about Google's RBE).
However, https://github.com/bazelbuild/remote-apis-sdks doesn't support node properties at the moment, which, for example, makes it impossible to use the remotetool to debug actions that use remote persistent workers.
Suggested fix
Introduce optional node properties specification throughout the rexec client layer, starting with adding it to the command proto:
and then reading these in GetDirectoryTree, passing them through to rexec here, here and here.
Please let me know if you're okay with this plan, and I'll try to send a PR shortly.
Thank you!
The text was updated successfully, but these errors were encountered: