Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0] Add bazel query --output_file option, which writes query results directly to a file #24539

Closed
wants to merge 1 commit into from
Closed

[8.0.0] Add bazel query --output_file option, which writes query results directly to a file #24539

wants to merge 1 commit into from

Conversation

iancha1992
Copy link
Member

This is a proposed fix for #24293

This speeds up a fully warm bazel query ... by 23.7%, reducing wall time from 1m49s to 1m23s

$ time bazel query '...' --output=streamed_proto > queryoutput4.streamedproto

real    1m48.768s
user    0m27.410s
sys     0m19.646s

$ time bazel query '...' --output=streamed_proto --output_file=queryoutput5.streamedproto

real    1m22.920s
user    0m0.045s
sys     0m0.016s

💁‍♂️ Note: when combined with #24305, total wall time is 37s, an overall reduction of 66%.

Closes #24298.

PiperOrigin-RevId: 700583890
Change-Id: Ic13f0611aca60c2ce8641e72a0fcfc330f13c803

Commit 791e1f7

@keithl-stripe @iancha1992
Add bazel query --output_file option, which writes query results di…
ad10633 
…rectly to a file

This is a proposed fix for bazelbuild#24293

This speeds up a fully warm `bazel query ...` by 23.7%, reducing wall time from 1m49s to 1m23s

```
$ time bazel query '...' --output=streamed_proto > queryoutput4.streamedproto

real    1m48.768s
user    0m27.410s
sys     0m19.646s

$ time bazel query '...' --output=streamed_proto --output_file=queryoutput5.streamedproto

real    1m22.920s
user    0m0.045s
sys     0m0.016s
```

_💁‍♂️ Note: when combined with bazelbuild#24305, total wall time is 37s, an overall reduction of 66%._

Closes bazelbuild#24298.

PiperOrigin-RevId: 700583890
Change-Id: Ic13f0611aca60c2ce8641e72a0fcfc330f13c803
@iancha1992 iancha1992 requested a review from a team as a code owner December 2, 2024 23:43
@google-cla Google CLA
Copy link

google-cla bot commented Dec 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@iancha1992 iancha1992 mentioned this pull request Dec 2, 2024
Open
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Dec 2, 2024
@iancha1992 iancha1992 requested review from jin and zhengwei143 and removed request for a team December 2, 2024 23:44
@iancha1992
Copy link
Member Author

iancha1992 commented Dec 2, 2024 •
edited
Loading

@keithl-stripe can you please sign the CLA?

@iancha1992 iancha1992 added team-Performance Issues for Performance teams team-Core Skyframe, bazel query, BEP, options parsing, bazelrc labels Dec 2, 2024
@keithl-stripe
Copy link
Contributor

@keithl-stripe can you please sign the CLA?

I did...

Screenshot 2024-12-03 at 8 54 00 AM

I don't know why my email address is showing up as 79670223+keithl-stripe​@users.noreply.github.com

Screenshot 2024-12-03 at 8 57 33 AM

I did have this box checked - though I don't think I performed any "web-based Git operations"

Screenshot 2024-12-03 at 8 58 11 AM

Any ideas on how to resolve this?

@iancha1992
Copy link
Member Author

iancha1992 commented Dec 3, 2024 •
edited
Loading

@keithl-stripe can you please sign the CLA?

I did...

Screenshot 2024-12-03 at 8 54 00 AM I don't know why my email address is showing up as `79670223+keithl-stripe​@users.noreply.github.com` Screenshot 2024-12-03 at 8 57 33 AM I did have this box checked - though I don't think I performed any "web-based Git operations" Screenshot 2024-12-03 at 8 58 11 AM Any ideas on how to resolve this?

@keithl-stripe Maybe configure your git global user.email to the correct one, instead of 79670223+keithl-stripe​@users.noreply.github.com?

@iancha1992
Copy link
Member Author

See #24511 (comment)

@iancha1992 iancha1992 closed this Dec 3, 2024
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Dec 3, 2024
@iancha1992 iancha1992 reopened this Dec 12, 2024
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Dec 12, 2024
@iancha1992 iancha1992 closed this Dec 12, 2024
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jin jin Awaiting requested review from jin

@zhengwei143 zhengwei143 Awaiting requested review from zhengwei143

Assignees
No one assigned
Labels
team-Core Skyframe, bazel query, BEP, options parsing, bazelrc team-Performance Issues for Performance teams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iancha1992 @keithl-stripe