-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Android Platforms by default for Android-related builds #19726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katre
force-pushed
the
enable-android-platforms
branch
3 times, most recently
from
October 10, 2023 17:08
94989cb
to
350c951
Compare
Ran downstream tests, identified several types of failures:
Next step before submitting this: send fixes for these. |
katre
force-pushed
the
enable-android-platforms
branch
from
October 11, 2023 21:33
c7ef46f
to
1e4e4ba
Compare
DO NOT MERGE - ADD RELNOTES HERE
katre
force-pushed
the
enable-android-platforms
branch
from
October 12, 2023 18:35
1e4e4ba
to
93b61f3
Compare
katre
changed the title
[WIP] Enable Android Platforms by default for Android-related builds.
Enable Android Platforms by default for Android-related builds
Oct 16, 2023
Downstream projects are mostly clean at this point. A typical error looks like
If any more downstream projects fail, assign an issue to me to triage. |
github-actions
bot
added
the
awaiting-review
PR is awaiting review from an assigned reviewer
label
Oct 16, 2023
gregestren
approved these changes
Oct 16, 2023
iancha1992
added
the
team-Configurability
platforms, toolchains, cquery, select(), config transitions
label
Oct 16, 2023
lberki
approved these changes
Oct 17, 2023
github-actions
bot
removed
the
awaiting-review
PR is awaiting review from an assigned reviewer
label
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16285.
RELNOTES: Enable Platforms and Toolchains for Android. Android projects will need to stop passing the legacy flag
--fat_apk_cpu
, and instead use--android_platforms
using platforms defined with the@platforms//os:android
constraint. The https://github.com/bazelbuild/rules_android repository defines four standard Android platforms for projects that use those rules,@rules_android//:armeabi-v7a
,@rules_android//:arm64-v8a
,@rules_android//:x86
,@rules_android//:x86_64
.Blog post describing these changes to follow.