Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect debug info context from implementation deps #19725

Conversation

thii
Copy link
Member

@thii thii commented Oct 4, 2023

Fixes #19146

@thii thii force-pushed the t/collect-debug-info-context-from-implementation-deps branch 2 times, most recently from 1442f96 to c50c1a7 Compare October 5, 2023 09:58
@thii thii force-pushed the t/collect-debug-info-context-from-implementation-deps branch from c50c1a7 to d88c7f3 Compare October 5, 2023 10:15
@thii thii marked this pull request as ready for review October 5, 2023 10:36
@thii thii requested a review from oquenchil as a code owner October 5, 2023 10:36
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Rules-CPP Issues for C++ rules labels Oct 5, 2023
@oquenchil oquenchil requested review from buildbreaker2021 and removed request for oquenchil October 9, 2023 12:27
@buildbreaker2021 buildbreaker2021 self-assigned this Oct 16, 2023
@buildbreaker2021 buildbreaker2021 added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 16, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 16, 2023
@thii thii deleted the t/collect-debug-info-context-from-implementation-deps branch October 16, 2023 12:31
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Oct 16, 2023
@iancha1992
Copy link
Member

@bazel-io fork 6.4.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Oct 16, 2023
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Oct 16, 2023
Fixes bazelbuild#19146

Closes bazelbuild#19725.

PiperOrigin-RevId: 573751305
Change-Id: I9b5df85dc5e52822b3a0b44fc42d90b727a5abf0
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Oct 16, 2023
Fixes bazelbuild#19146

Closes bazelbuild#19725.

PiperOrigin-RevId: 573751305
Change-Id: I9b5df85dc5e52822b3a0b44fc42d90b727a5abf0
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Oct 16, 2023
Fixes bazelbuild#19146

Closes bazelbuild#19725.

PiperOrigin-RevId: 573751305
Change-Id: I9b5df85dc5e52822b3a0b44fc42d90b727a5abf0
keertk pushed a commit that referenced this pull request Oct 16, 2023
Fixes #19146

Closes #19725.

Commit
e55fee2

PiperOrigin-RevId: 573751305
Change-Id: I9b5df85dc5e52822b3a0b44fc42d90b727a5abf0

Co-authored-by: Thi Don <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cc_library doesn't collect debug_context(s) from implementation_deps
5 participants