Skip to content
This repository has been archived by the owner on Sep 8, 2023. It is now read-only.

There should be a coding standards page. #267

Open
aiuto opened this issue Aug 20, 2020 · 0 comments
Open

There should be a coding standards page. #267

aiuto opened this issue Aug 20, 2020 · 0 comments

Comments

@aiuto
Copy link
Contributor

aiuto commented Aug 20, 2020

Under contributors guide.
The patch acceptance page https://bazel.build/basics/patching.html should point to it

Things to mention

  • tests are required for all new/changed behavior
  • that license headers are required in all source files. list the exceptions
  • that the PR description must have well worded release notes for new features or visible behavior changes

Things to warn about

  • assuming / is the path separator
  • assuming local execution only
  • there must be others....
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant