Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new_pod_repository with tags fails #199

Open
SwapnilNighot opened this issue Feb 23, 2022 · 5 comments
Open

new_pod_repository with tags fails #199

SwapnilNighot opened this issue Feb 23, 2022 · 5 comments

Comments

@SwapnilNighot
Copy link

SwapnilNighot commented Feb 23, 2022

Hi,
I am trying to use the new_pod_repository with the tag in the pods URL as below

new_pod_repository(
  name = "SDWebImage",
  url = "https://github.com/SDWebImage/SDWebImage/archive/refs/tags/5.12.3.zip",
  generate_header_map = 1
)

it's failing with the error as below.

Updating Pod SDWebImage...
_exec failed 4  RepoToolsCore/RepoActions.swift:257: Fatal error: Missing podspec ( ./SDWebImage.podspec ) inside /MY_PROJECT_PATH/Vendor/SDWebImage

Also it creates the additional folder with the tag name (Vendor/SDWebImage/SDWebImage-5.12.3).
I thought may be it's failing because of it and tried putting podspec_url but it's still failing.

Where as, if I use it without the tag as below

new_pod_repository(
  name = "SDWebImage",
  url = "https://github.com/SDWebImage/SDWebImage/archive/5.12.3.zip",
  generate_header_map = 1
)

Is working as expected.

Is this behaviour is as expected ?

@lexuanquynh
Copy link

same issue. Bazel can't read generate_header_map property. I don't know why.

@Jacky-LinPeng
Copy link

Did you finally have a solution?

@SwapnilNighot
Copy link
Author

Like I mentioned in the ticket, I am able to consume the pod by using the url without tags.
Like this - url = "https://github.com/SDWebImage/SDWebImage/archive/5.12.3.zip"

@Jacky-LinPeng
Copy link

Like I mentioned in the ticket, I am able to consume the pod by using the url without tags.
Like this - url = "https://github.com/SDWebImage/SDWebImage/archive/5.12.3.zip"

After downloading SDWebImage dependencies using new_pod_repository, how do you integrate them into your demo project? I encountered a problem when I imported the "sdwebimage.h" project saying the header file did not exist

@johndpope
Copy link
Contributor

try looking at full path where it falls out - then hard code like this
podspec_url = "Vendor/Texture/Texture-3.1.0/Texture.podspec",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants