Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add py.typed marker indicating provision of inlined types #65

Open
acartine opened this issue Mar 6, 2023 · 0 comments · May be fixed by #70
Open

add py.typed marker indicating provision of inlined types #65

acartine opened this issue Mar 6, 2023 · 0 comments · May be fixed by #70

Comments

@acartine
Copy link

acartine commented Mar 6, 2023

when enabling pylance/pyright typing i encountered some errors related to flask-pydantic. when i reached out to the maintainer

microsoft/pyright#4733 (comment)

he provided this feedback.

The flask_pydantic package appears to have inline type annotations within its own code. However, it is not marked as "py.typed" (i.e. it doesn't have a "py.typed" marker file indicating that it has inlined types). You may want to reach out to the maintainers of the library to encourage them to add this marker file. For more details, refer to this documentation.

i'm happy to give this a shot with a PR but wanted to have some discussion about it first. Thanks in advance!
MarekPikula added a commit to MarekPikula/flask-pydantic that referenced this issue Apr 18, 2023
@MarekPikula
Improve typing in the module
ec2b14b 
Fixes bauerji#65

- make it pass mypy tests (i.e., improve type hinting)
- add mypy test to CI
- add py.typed to setup so that other packages recognize it's typed
- enable async view function decoration (via ensure_sync() as noted on
  https://flask.palletsprojects.com/en/latest/async-await/#extensions)

Signed-off-by: Marek Pikuła <[email protected]>
MarekPikula added a commit to MarekPikula/flask-pydantic that referenced this issue Apr 18, 2023
@MarekPikula
Improve typing in the module
b1a07d3 
Fixes bauerji#65

- make it pass mypy tests (i.e., improve type hinting)
- add mypy test to CI
- add py.typed to setup so that other packages recognize it's typed
- enable async view function decoration (via ensure_sync() as noted on
  https://flask.palletsprojects.com/en/latest/async-await/#extensions)

Signed-off-by: Marek Pikuła <[email protected]>
MarekPikula added a commit to MarekPikula/flask-pydantic that referenced this issue Apr 18, 2023
@MarekPikula
Improve typing in the module
24b321e 
Fixes bauerji#65

- make it pass mypy tests (i.e., improve type hinting)
- add mypy test to CI
- add py.typed to setup so that other packages recognize it's typed
- enable async view function decoration (via ensure_sync() as noted on
  https://flask.palletsprojects.com/en/latest/async-await/#extensions)

Signed-off-by: Marek Pikuła <[email protected]>
MarekPikula added a commit to MarekPikula/flask-pydantic that referenced this issue Apr 18, 2023
@MarekPikula
Improve typing in the module
f6c2afc 
Fixes bauerji#65

- make it pass mypy tests (i.e., improve type hinting)
- add mypy test to CI
- add py.typed to setup so that other packages recognize it's typed
- enable async view function decoration (via ensure_sync() as noted on
  https://flask.palletsprojects.com/en/latest/async-await/#extensions)

Signed-off-by: Marek Pikuła <[email protected]>
@MarekPikula MarekPikula linked a pull request Apr 18, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve typing MarekPikula/flask-pydantic
1 participant
@acartine