And here's evidence that Shellcheck fires up fine https://github.com/basecamp/omakub/actions/runs/9482343428/job/26127026453?pr=101

I know shellcheck likes this, but imo it isn't really needed, and imo kind of ruins the cleanness of the codebase, because the code will still work

#!/usr/bin/env bash

I know shellcheck likes this, but imo it isn't really needed,

Explanation here: https://stackoverflow.com/a/25202821

I'd say if we want to start turning off rules that Shellcheck ships with, it's perphaps a sign that we don't want Shellcheck to begin with.

Disagree that it ruins cleanliness - it's just one comment line in the scripts, and it ensures the scripts will work correctly (by invoking bash) even if the user has switched to a different shell after installation.

@dhh I keep on rebasing changes (you move fast!), so in order to proceed with integrating the codebase with Shellcheck, if you're still interested with this I think we should merge ASAP.

Hmm, looking through the list of changes, I'm not sure I'm seeing enough value here. I like the idea in theory, but the practice of the diff isn't convincing enough imo. Appreciate you investigating this though!

@dhh Separate from the other changes, would you accept the addition of a #!/usr/bin/env bash shebang to the scripts to ensure they will be invoked with bash even if the user has changed their shell after installation? IMO that part is valuable