Gutenberg: contribute type migration for menu-item

[bangank36]

Summary

Use this issue to track the progress of migration to typescript for menu-item component

🚧 Proposed PR:

MenuItem: Refactor to TypeScript

• Addressed feedbacks, waiting for review again Gutenberg: contribute type migration for menu-item #79 (comment)

Reference

Prior effort PR
Migration on menu-items-choice, type discussion
Collection migration issue
Kick off discussion (on storybook)

Found a blog on the component as prop, it suits for icon issue but it also answer some question raised with the Navigator Context #19

[bangank36]

28 July 2023

• icon prop seems off, link to readme is incorrect as well, so I used IconType for now

29 July 2023

• menuItem has been used on several places and mismatch type can be seen on

1. label: make it option
2. icon: isSelected && check result false | Element is mismatched on menu-items-choice tools-panel-header
3. variant on tools-panel-header: not relevant

[bangank36]

06 Aug 2023

Addressing the feedback

1. variant can not be removed, comment

• Since variant is passed to button component, it can not be removed, check ...buttonProps

2. Using WordPressComponentProps

• This is what I am missing from the contributing notes

Extend existing components’ props if possible, especially when a component internally forwards its props to another component in the package.
If the component forwards its ...restProps to an underlying element/component, you should use the WordPressComponentProps type for the component's props:

3. Add JSDoc above export

4. Rename type file

5. Import button props

6. IconPosition fix

7. Remove all button props

8. Rebase to latest changes & update changelogs

[bangank36]

Closed as merged