Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mvn plugin updates #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/mvn plugin updates #33

wants to merge 2 commits into from

Conversation

arburk
Copy link
Contributor

@arburk arburk commented Mar 25, 2020

  • updated outdated maven plugins
  • addressed maven compile warnings and suggested code optimizations

@arburk arburk requested review from MarkusTiede and bsolar17 March 25, 2020 19:04
@arburk arburk requested a review from seejaybee as a code owner March 25, 2020 19:04
MarkusTiede
MarkusTiede approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@MarkusTiede MarkusTiede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty big change - I guess somehow been automatically done e.g. be the IDE?

Assuming that this is the case --> approving

@arburk
Copy link
Contributor Author

arburk commented Mar 26, 2020

This is a pretty big change - I guess somehow been automatically done e.g. be the IDE?

Assuming that this is the case --> approving

Yes of course, refactored with IDEA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkusTiede MarkusTiede MarkusTiede approved these changes

@bsolar17 bsolar17 Awaiting requested review from bsolar17 bsolar17 is a code owner

@seejaybee seejaybee Awaiting requested review from seejaybee seejaybee is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arburk @MarkusTiede