Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(bal-select): control value accessor of bal-select broken in case of turned on typeahead #961

Closed
1 task done
Zankel-Engineering opened this issue Jun 21, 2023 · 3 comments
Labels
🐛 bug Something isn't working
Milestone

Comments

@Zankel-Engineering
Copy link

Current Behavior

Hello folks,

we use your design system in a product :-). In the application we rely heavily on reactive forms. Means we use the reactive form to model the data and implement our own control value accessor components. In one of the components we have the bal-select, which we use with a fuzzy search to choose a profession, since the list of possible professions is to long and will lead to problems with too many DOM-nodes without the prefiltering. It is possible to save and restore the model. In case of a restore I can see, that the value is correctly set on the parent formgroup, the bal-select also is filtered down to just this one value, but the view is not correct, since the typeadhead is still empty.

Please see attached screenshot:
bal-select

Expected Behavior

The value is correctly set.

Steps to Reproduce

  1. Build a parent-component with a form-group
  2. Build child-component as control-value-accessor with a childform
  3. Add the bal-select with typeahead to the child-component
  4. Set a value on the parent-form-group that matches the options

Version

13.0.0

Browsers

Chrome, Microsoft Edge

Device

Desktop

Code Reproduction URL

No response

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Zankel-Engineering Zankel-Engineering added the 🐛 bug Something isn't working label Jun 21, 2023
@Zankel-Engineering
Copy link
Author

Hi guys, I guess this issue is not on the base application side. But you are never sure. I closed the other one, their I offered that we could try to get the design system running on the VDI, so that I can take some burden from your shoulders at least for the bugs that occur in the base application and if not wished I could make better bug reports if I would be able to debug the design system on the VDI. Let me know what you are thinking?

@hirsch88 hirsch88 self-assigned this Aug 8, 2023
@Zankel-Engineering
Copy link
Author

Hi guys, while further exploring the issue I recognized that for example when I have the control value accessor around the bal-select in a modal window it only occurs every second time. I am not sure if that helps. I also tried to reset the issue the value after a delay, but this didn't fix the problem.

@hirsch88 hirsch88 added this to the ✏️ Forms milestone Oct 12, 2023
@hirsch88 hirsch88 removed their assignment Mar 12, 2024
@hirsch88
Copy link
Member

hirsch88 commented Dec 5, 2024

deprecated component

@hirsch88 hirsch88 closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants