Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat(tabs): support brand icons #1524

Merged
merged 22 commits into from
Dec 6, 2024
Merged

✨ feat(tabs): support brand icons #1524

merged 22 commits into from
Dec 6, 2024

Conversation

github-actions[bot]
Copy link
Contributor

closes #1522

@github-actions github-actions bot added the ✨ feature New feature or request label Nov 28, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 8:38am
design-system-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 8:38am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 72c90d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@baloise/ds-core Minor
@baloise/ds-angular-common Minor
@baloise/ds-angular-legacy Minor
@baloise/ds-angular-module Minor
@baloise/ds-angular Minor
@baloise/ds-react Minor
@baloise/ds-table Minor
@baloise/ds-testing Minor
@baloise/ds-vue Minor
docs Patch
e2e Patch
@baloise/ds-brand-icons Minor
@baloise/ds-css Minor
@baloise/ds-devkit Minor
@baloise/ds-favicons Minor
@baloise/ds-fonts Minor
@baloise/ds-icons Minor
@baloise/ds-maps Minor
@baloise/ds-styles Minor
@baloise/ds-tokens Minor
@baloise/ds-nx Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

hirsch88
hirsch88 approved these changes Nov 29, 2024
View reviewed changes
e2e/package.json Outdated Show resolved Hide resolved
packages/core/src/components/bal-tabs/bal-tab-item/bal-tab-item.tsx Outdated Show resolved Hide resolved
packages/core/src/components/bal-tabs/bal-tabs.tsx Show resolved Hide resolved
packages/core/src/components/bal-tabs/components/tab-label.sass Outdated Show resolved Hide resolved
@tklueber
Copy link
Collaborator

tklueber commented Dec 6, 2024 •
edited by github-actions bot
Loading

📸 Create Base Image finished!

Specs: bal-tabs.visual.cy.ts

Check out the action on GitHub ↗︎

@hirsch88
Copy link
Member

hirsch88 commented Dec 6, 2024 •
edited by github-actions bot
Loading

🚨 Create Base Image Failed!

Specs: bal-nav-menu-bar.visual.cy

Check out the action on GitHub ↗︎

@hirsch88 hirsch88 merged commit 6d1a4e1 into main Dec 6, 2024
18 checks passed
@hirsch88 hirsch88 deleted the feat/issue-1522 branch December 6, 2024 08:49
@hirsch88 hirsch88 mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirsch88 hirsch88 hirsch88 approved these changes

@m4rc0z m4rc0z Awaiting requested review from m4rc0z m4rc0z is a code owner

@yannickholzenkamp yannickholzenkamp Awaiting requested review from yannickholzenkamp yannickholzenkamp is a code owner

@mmarinkov mmarinkov Awaiting requested review from mmarinkov mmarinkov is a code owner

Assignees

@tklueber tklueber

Labels
✨ feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ feat(tabs): support brand icons
2 participants
@tklueber @hirsch88