Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor(select): create new component Drop-Down #1349

Closed
1 task done
hirsch88 opened this issue Mar 18, 2024 · 2 comments · Fixed by #1353
Closed
1 task done

♻️ refactor(select): create new component Drop-Down #1349

hirsch88 opened this issue Mar 18, 2024 · 2 comments · Fixed by #1353
Assignees
Labels
♻️ refactor Improve existing code
Milestone

Comments

@hirsch88
Copy link
Member

Summary

Drop-Down components are used to gather user-provided information from a range of options.

Additional Information

Linked to #1067


Screenshot 2024-03-18 at 09 34 45 Screenshot 2024-03-18 at 09 35 05

Code of Conduct

  • I agree to follow this project's Code of Conduct
@hirsch88 hirsch88 added the ♻️ refactor Improve existing code label Mar 18, 2024
@hirsch88 hirsch88 added this to the ♻️ Select milestone Mar 18, 2024
@hirsch88 hirsch88 self-assigned this Mar 18, 2024
@hirsch88
Copy link
Member Author

/cib

Copy link
Contributor

Branch refactor/issue-1349 created!

github-actions bot added a commit that referenced this issue Mar 18, 2024
hirsch88 added a commit that referenced this issue Apr 17, 2024
* Create PR for #1349

* ♻️ refactor(select): create option component (#1356)

* Create PR for #1354

* add new component option

* add new component option

* fix a11y issues

* add interface of the component

* add output for visuals

* adjust ci

* update gitignore

* update base images

* adjust colors and sass vars

* update base images

* merge

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <[email protected]>
Co-authored-by: hirsch88 <[email protected]>

* ♻️ refactor(select): create new component option-list (#1357)

* Create PR for #1355

* add option list component

* update base images

* add labelledby for a11y

* add changeset

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <[email protected]>
Co-authored-by: hirsch88 <[email protected]>

* add first dropdown draft

* update spinner

* refactor in to utils

* format files

* update with prop options

* add docs

* format files

* support testing

* chore: Merge branch 'main' into refactor/issue-1349

* adjust component testing

* update component testing

* add component test for dropdown

* update dropdown

* update dropdown

* update dropdown

* autocomplete

* rename

* update dropdown

* update dropdown

* format files

* add a11y test

* add viusal tests

* update base images

* format files

* update angular output

* add testing lib migration

* update docs

* add required

* fix tests

* fix tests

* update docs

* chores

* create angular e2e test

* create angular e2e test

* fix doc styles

* update base images

* update docs

* fix chip hover

* remove old styles

* adjust invalid and disabled with chips

* fix z-index

* update multiple always with checkbox and improve form submit

* update multiple always with checkbox and improve form submit

* hide native select for a11y

* fix checkbox issue

* add log for visual type

* fix visual

* update base images

* update base images

* finish auto-fill

* fix safari autofill

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <[email protected]>
Co-authored-by: hirsch88 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ refactor Improve existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant